coreboot-kgpe-d16/src/mainboard
Keith Hui a298668b99 mb/asus/p2b*: Get rid of power button device
These boards have the same issue as [27272]:

Currently, two power buttons are exposed in ACPI, and detected by the
operating system.

> As per the ACPI specification, there are two types of power button
> devices:
> 1. Fixed hardware power button
> 2. Generic hardware power button
>
> Fixed hardware power button is added by the OSPM if POWER_BUTTON flag
> is not set in FADT by the BIOS. This device has its programming model
> in PM1x_EVT_BLK. All ACPI compliant OSes are expected to add this
> power button device by default if the power button FADT flag is not
> set.
>
> On the other hand, generic hardware power button can be used by
> platforms if fixed register space cannot be used for the power button
> device. In order to support this, power button device object with HID
> PNP0C0C is expected to be added to ACPI tables. Additionally,
> POWER_BUTTON flag should be set to indicate the presence of control
> method for power button.
>
> [i440BX] mainboards implemented the generic hardware power button in
> a broken manner i.e. power button object with HID PNP0C0C is added to
> ACPI however none of the boards set POWER_BUTTON flag in FADT. This
> results in Linux kernel adding both fixed hardware power button as
> well as generic hardware power button to the list of devices present
> on the system. Though this is mostly harmless, it is logically
> incorrect and can confuse any userspace utilities scanning the ACPI
> devices.

Hardware tests on the P2B-LS shows the generic hardware power button
is not working anyway - with FADT power button flag set, the board
could not power off with the button.

This change removes the generic hardware power button from all P2B
mainboards and relies completely on the fixed hardware power button.

TEST=Booted on P2B-LS, Linux detects only fixed hardware power
button, button still powers off.

[27272]: https://review.coreboot.org/27272

Change-Id: I0f5b7aaf32366360de3cce58cd742651a2bb46ba
Signed-off-by: Keith Hui <buurin@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40007
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
2020-05-02 17:10:06 +00:00
..
51nb src/mb: Remove unneeded spaces before/after tabs 2020-04-10 22:30:06 +00:00
adlink
amd mb/amd/padmelon: Remove PS/2 keyboard driver selection 2020-04-30 21:44:12 +00:00
aopen mainboard/aopen: Use SPDX for GPL-2.0-only files 2020-04-06 13:39:53 +00:00
apple mainboard/apple: Use SPDX for GPL-2.0-only files 2020-04-04 15:35:32 +00:00
asrock nb/intel/haswell: Deprecate WDB params in pei_data 2020-04-22 13:46:42 +00:00
asus mb/asus/p2b*: Get rid of power button device 2020-05-02 17:10:06 +00:00
bap mainboard/bap: Use SPDX for GPL-2.0-only files 2020-04-04 15:06:12 +00:00
biostar src/mainboard: Const'ify pci_devfn_t devices 2020-04-23 22:21:11 +00:00
cavium mainboard/cavium: Use SPDX for GPL-2.0-only files 2020-04-06 13:40:04 +00:00
compulab mainboard/compulab: Use SPDX for GPL-2.0-only files 2020-04-04 15:08:13 +00:00
elmex mainboard/elmex: Use SPDX for GPL-2.0-only files 2020-04-04 15:07:17 +00:00
emulation src/mainboard: Const'ify pci_devfn_t devices 2020-04-23 22:21:11 +00:00
facebook mb/facebook/monolith: Add fmd files for 6MB BIOS area 2020-04-14 09:49:10 +00:00
foxconn mainboard/foxconn: Use SPDX for GPL-2.0-only files 2020-04-04 15:43:43 +00:00
getac device: Constify struct device * parameter to write_acpi_tables 2020-04-28 19:21:49 +00:00
gigabyte mb/gigabyte/ga-g41m-es2l: Remove unused variable 'dev' 2020-04-23 22:20:31 +00:00
gizmosphere mainboard/gizmosphere: Use SPDX for GPL-2.0-only files 2020-04-04 15:49:42 +00:00
google mb/google/reef: Add and use VBT 2020-05-02 17:08:25 +00:00
hp mainboard/hp: Use SPDX for GPL-2.0-only files 2020-04-04 15:54:55 +00:00
ibase mainboard/ibase: Use SPDX for GPL-2.0-only files 2020-04-04 15:56:44 +00:00
intel mb/intel/cedarisland_crb: Enable P2SB device 2020-05-01 23:11:44 +00:00
jetway mainboard/jetway: Use SPDX for GPL-2.0-only files 2020-04-06 13:38:55 +00:00
kontron mb/kontron/ktqm77: Extend SATA CMOS option with "legacy" mode 2020-04-15 21:10:46 +00:00
lenovo device: Constify struct device * parameter to acpi_fill_ssdt() 2020-04-28 19:50:26 +00:00
libretrend fsp2_0: Clean up around config FSP_USE_REPO 2020-04-05 23:26:04 +00:00
lippert mainboard/lippert: Use SPDX for GPL-2.0-only files 2020-04-05 17:45:36 +00:00
msi mainboard/msi: Use SPDX for GPL-2.0-only files 2020-04-04 16:25:29 +00:00
ocp md/tiogapass: move all *.h to dir and make them global 2020-05-01 22:13:08 +00:00
opencellular mainboard/opencellular: Use SPDX for GPL-2.0-only files 2020-04-05 17:46:05 +00:00
packardbell src: Remove not used 'include <smbios.h>' 2020-05-01 06:16:33 +00:00
pcengines mb/pcengines/apu1: Remove PS/2 keyboard driver configuration 2020-04-30 21:44:06 +00:00
portwell mainboard/portwell: Use SPDX for GPL-2.0-only files 2020-04-04 15:00:48 +00:00
protectli fsp2_0: Clean up around config FSP_USE_REPO 2020-04-05 23:26:04 +00:00
purism mb/purism/librem_bdw: Convert to use override devicetree 2020-05-02 17:07:47 +00:00
razer fsp2_0: Clean up around config FSP_USE_REPO 2020-04-05 23:26:04 +00:00
roda src/mainboard: Use 'const' to set pnp_devfn_t statically 2020-04-14 09:56:33 +00:00
samsung src/mainboard: Const'ify pci_devfn_t devices 2020-04-23 22:21:11 +00:00
sapphire mainboard/sapphire: Use SPDX for GPL-2.0-only files 2020-04-04 15:25:36 +00:00
scaleway mainboard/scaleway: Use SPDX for GPL-2.0-only files 2020-04-06 13:39:32 +00:00
siemens mainboard/siemens: Use SPDX for GPL-2.0-only files 2020-04-04 16:30:51 +00:00
sifive mainboard/sifive: Use SPDX for GPL-2.0-only files 2020-04-04 15:19:45 +00:00
supermicro mb/supermicro/x11: drop DeepSx config from devicetree 2020-05-02 17:02:58 +00:00
system76 Do not select USE_BLOBS 2020-04-15 19:11:08 +00:00
ti mainboard/ti: Use SPDX for GPL-2.0-only files 2020-04-04 15:22:06 +00:00
up Do not select USE_BLOBS 2020-04-15 19:11:08 +00:00
Kconfig