338d668b6f
`pmc_send_ipc_cmd()` expects the caller to pass in a pointer to a valid request and response buffer. However, early_tcss driver was passing in a NULL pointer for response buffer which would result in invalid access by `pmc_send_ipc_cmd()`. Currently, the response buffer is not used in `update_tcss_mux()`. So, this change drops the passing of `rbuf` parameter to `send_pmc*` helpers and instead uses a local `rsp` variable in the respective functions. All the PMC functions used in early_tcss driver return some kind of response. These should be checked to return appropriate response code back to the caller. However, this needs to be done as a separate change. Change-Id: I215af85feed60b6beee17f28e3d65daa9ad4ae69 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/51232 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
||
---|---|---|
.. | ||
acpi | ||
bootblock | ||
include/soc | ||
romstage | ||
spd | ||
acpi.c | ||
chip.c | ||
chip.h | ||
chipset.cb | ||
cpu.c | ||
crashlog_lib.c | ||
early_tcss.c | ||
elog.c | ||
espi.c | ||
finalize.c | ||
fsp_params.c | ||
gpio.c | ||
gspi.c | ||
i2c.c | ||
Kconfig | ||
lockdown.c | ||
Makefile.inc | ||
me.c | ||
meminit.c | ||
p2sb.c | ||
pmc.c | ||
pmutil.c | ||
reset.c | ||
smihandler.c | ||
soundwire.c | ||
spi.c | ||
systemagent.c | ||
uart.c | ||
xhci.c |