coreboot-kgpe-d16/src/soc/intel/tigerlake
Furquan Shaikh 338d668b6f soc/intel/tigerlake: Fix NULL being passed for response buffer
`pmc_send_ipc_cmd()` expects the caller to pass in a pointer to a valid
request and response buffer. However, early_tcss driver was passing in
a NULL pointer for response buffer which would result in invalid
access by `pmc_send_ipc_cmd()`.

Currently, the response buffer is not used in `update_tcss_mux()`. So,
this change drops the passing of `rbuf` parameter to `send_pmc*`
helpers and instead uses a local `rsp` variable in the respective
functions. All the PMC functions used in early_tcss driver return some
kind of response. These should be checked to return appropriate
response code back to the caller. However, this needs to be done as a
separate change.

Change-Id: I215af85feed60b6beee17f28e3d65daa9ad4ae69
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51232
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
2021-03-05 03:53:16 +00:00
..
acpi soc/intel: Include gfx.asl from northbridge 2021-03-01 08:32:47 +00:00
bootblock soc/intel: Drop bootblock_cpu_init() function 2021-03-01 19:43:04 +00:00
include/soc soc/intel: Drop bootblock_cpu_init() function 2021-03-01 19:43:04 +00:00
romstage soc/intel: Drop romstage_pch_init() function 2021-03-01 19:41:17 +00:00
spd lp4x: Add new memory parts and generate SPDs 2020-11-30 08:03:35 +00:00
acpi.c soc/intel: Factor out identical acpigen GPIO helpers 2021-03-01 19:37:56 +00:00
chip.c soc/intel/{adl,jsl,ehl,tgl}: Remove ITSS polarity restore 2021-02-24 11:28:45 +00:00
chip.h soc/intel: Retype CnviBtAudioOffload devicetree option 2021-03-03 09:02:03 +00:00
chipset.cb soc/intel: hook up new gpio device in the soc chips 2020-12-30 00:30:04 +00:00
cpu.c src: Remove unused <arch/cpu.h> 2021-02-11 10:25:23 +00:00
crashlog_lib.c soc/intel/tigerlake: Re-use existing define in CrashLog implementation 2021-03-03 09:02:16 +00:00
early_tcss.c soc/intel/tigerlake: Fix NULL being passed for response buffer 2021-03-05 03:53:16 +00:00
elog.c ELOG: Add const qualifier for chipset_power_state 2021-01-23 20:18:11 +00:00
espi.c soc/intel/{skl,cnl,xsp,icl,tgl,ehl,adl,jsl}: use common LPC mirroring 2021-01-25 09:06:10 +00:00
finalize.c
fsp_params.c soc/intel/tigerlake: Enable end of post support in FSP 2021-02-22 23:20:32 +00:00
gpio.c
gspi.c
i2c.c
Kconfig soc/intel: Factor out common smmrelocate.c 2021-03-03 09:06:09 +00:00
lockdown.c
Makefile.inc soc/intel: Factor out common smmrelocate.c 2021-03-03 09:06:09 +00:00
me.c
meminit.c soc/intel/tgl and tgl mb/google,intel: Use the newly added meminit block driver 2021-01-25 08:48:57 +00:00
p2sb.c
pmc.c
pmutil.c soc/intel/*/pmutil.c: Align cosmetics across platforms 2021-02-24 11:34:42 +00:00
reset.c
smihandler.c soc/intel: Remove unused <console/console.h> 2021-02-15 10:50:09 +00:00
soundwire.c
spi.c src/soc/intel/tigerlake: Add SPI DMI Destination ID 2020-12-08 22:57:45 +00:00
systemagent.c soc/intel: Replace SA_PCIEX_LENGTH Kconfig options 2021-01-30 23:14:08 +00:00
uart.c soc/intel: Remove unused <console/console.h> 2021-02-15 10:50:09 +00:00
xhci.c soc/intel/common: Adapt XHCI elog driver for reuse 2020-12-10 17:45:47 +00:00