a7a57701d6
FSP was setting up the TCO registers to be mapped at 0x400. However, the SMBus initialization in romstage was mapping its I/O BAR to 0x400 as well. The result seemed to cause the TCO register to be hidden. However, the board was rebooting in depthcharge when the SMBus device was enabled from a TCO timeout. As the TCO timer was halted before the double resource assignment it's not clear how the TCO was getting re-enabled. In either case, the current behavior is wrong. BUG=chrome-os-partner:42407 BRANCH=None TEST=Built and booted glados w/ SMBus enabled. Original-Change-Id: I43c0d67a76abac51ccfd5105245792981fbcd04c Original-Signed-off-by: Aaron Durbin <adurbin@chromium.org> Original-Reviewed-on: https://chromium-review.googlesource.com/290363 Original-Reviewed-by: Duncan Laurie <dlaurie@chromium.org> Change-Id: I3839290768c27626c3fd2d67d5de94c291c1386e Signed-off-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: http://review.coreboot.org/11180 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi <pgeorgi@google.com> |
||
---|---|---|
.. | ||
acpi | ||
bootblock | ||
include/soc | ||
microcode | ||
romstage | ||
acpi.c | ||
chip.c | ||
chip.h | ||
cpu.c | ||
cpu_info.c | ||
elog.c | ||
finalize.c | ||
flash_controller.c | ||
gpio.c | ||
igd.c | ||
Kconfig | ||
lpc.c | ||
Makefile.inc | ||
memmap.c | ||
monotonic_timer.c | ||
pch.c | ||
pcie.c | ||
pcr.c | ||
pei_data.c | ||
pmc.c | ||
pmutil.c | ||
ramstage.c | ||
smbus.c | ||
smbus_common.c | ||
smi.c | ||
smihandler.c | ||
smmrelocate.c | ||
systemagent.c | ||
tsc_freq.c | ||
uart.c | ||
uart_debug.c | ||
xhci.c |