GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
coreboot-kgpe-d16/src/soc/intel/apollolake
History
Hannah Williams 1177bf5165 soc/intel/common/block/pmc: Fix ACPI BAR and PCI_COMMAND in PMC config space 
read_resources in common/block/pmc/pmc.c is corrupting the BAR
at offset 0x20.

pch_pmc_read_resources
                      |
                      pci_dev_read_resources
                                            |
                                            pci_get_resource
Within pci_get_resource, the BAR is read and written back. Since read of
ACPI BAR does not return the correct value, the subsequent write
corrupts the BAR. Hence re-programming the BAR. Also, reading PMC
STATUSCOMMAND register does not return bit 0 correctly in
pci_dev_enable_resources. This causes IO SPACE ACCESS to get disabled.
Hence making sure IO ACCESS gets enabled by setting dev->command

TEST=Can boot to OS
Without this change coreboot will be stuck at "Disabling ACPI via APMC:"

Change-Id: I27062419d06127951ecbbb641835d06ca39ff435
Signed-off-by: Hannah Williams <hannah.williams@intel.com>
Reviewed-on: https://review.coreboot.org/23230
Reviewed-by: Subrata Banik <subrata.banik@intel.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
2018-02-05 18:53:16 +00:00
..
acpi soc/intel/apollolake: add _RMV attributes to eMMC device ACPI 2017-12-14 22:16:13 +00:00
bootblock src/soc/intel/apollolake: move TCO1 disable into bootblock 2017-11-21 17:53:02 +00:00
include/soc soc/intel/apollolake: Clear RTC failure bit after reading it 2018-02-05 00:49:12 +00:00
acpi.c soc/intel/apollolake: Set ACPI_FADT_LOW_PWR_IDLE_S0 for S0ix 2018-01-16 19:31:39 +00:00
car.c soc/intel/apollolake: Use CPU common library code 2017-06-09 20:01:26 +02:00
chip.c soc/intel/apollolake: Remove set_subsystem() from SoC 2017-12-13 10:20:41 +00:00
chip.h ic2/designware: Move Intel i2c logic to shared driver 2017-12-22 16:39:42 +00:00
cpu.c soc/intel/common: Add missing SoC common function into SMM library 2017-12-22 01:41:30 +00:00
cse.c soc/intel/apollolake: Add file path check 2017-08-10 15:58:23 +00:00
elog.c soc/intel/apollolake: fix system reset eventlog 2017-04-28 15:58:49 +02:00
exit_car_fsp.S soc/intel/apollolake: Fix CONFIG_FSP_CAR build error 2017-08-17 17:51:51 +00:00
gpio_apl.c soc/intel/common/gpio: clean up logical to chipset mapping 2017-07-17 15:00:30 +00:00
gpio_glk.c soc/intel/apollolake: Bring in delta for GLK SOC 2017-07-21 03:59:09 +00:00
graphics.c intel: Prepare registers so Windows drivers are happier 2018-01-29 09:41:35 +00:00
heci.c soc/pci_devs.h: Use consistent naming in soc/pci_devs.h 2017-03-28 16:39:28 +02:00
i2c.c drivers/i2c/designware: reduce API complication for bus config 2018-01-25 22:36:30 +00:00
Kconfig soc/intel/common/block/pmc: Fix ACPI BAR and PCI_COMMAND in PMC config space 2018-02-05 18:53:16 +00:00
lpc.c soc/intel/common: Add option to pass SoC IO resource 2018-01-17 17:47:33 +00:00
Makefile.inc soc/intel/apollolake: Clean up UART code 2017-12-07 03:21:13 +00:00
meminit.c soc/intel/apollolake: Update memory HOB info save function 2017-07-26 17:52:32 +00:00
meminit_util_apl.c soc/intel/apollolake: Update memory HOB info save function 2017-07-26 17:52:32 +00:00
meminit_util_glk.c soc/intel/apollolake/meminit_util_glk.c: Check for NULL 2018-01-17 17:23:25 +00:00
memmap.c soc/intel/apollolake: Add PrmrrSize and SGX enable config 2017-09-27 06:46:18 +00:00
mmap_boot.c soc/intel/common/block: add bios caching to fast spi module 2017-06-05 00:21:39 +02:00
nhlt.c soc/intel/apollolake: Fix issues detected by checkpatch 2017-03-13 17:48:31 +01:00
pmc.c soc/intel/common/block: Add Intel common PMC controller support for KBL, APL 2017-12-02 03:20:07 +00:00
pmutil.c soc/intel/apollolake: Clear RTC failure bit after reading it 2018-02-05 00:49:12 +00:00
pnpconfig.c soc/intel/apollolake: Add PNP config 2017-12-02 05:26:05 +00:00
reset.c soc/intel/apollolake: Use common PMC for apollolake 2017-08-08 17:15:43 +00:00
romstage.c drivers/mrc_cache: move mrc_cache support to drivers 2017-12-17 18:29:41 +00:00
sd.c soc/intel/apollolake: Use SCS common code 2017-06-16 17:37:06 +02:00
smi.c soc/intel/common: Clean up PMC library GPE handling API 2017-10-12 22:13:39 +00:00
smihandler.c soc/intel/{apollolake, cannonlake, common, skylake}: Add _soc_ prefix in weak function 2017-12-23 05:23:09 +00:00
spi.c soc/intel/apollolake: Make use of Intel SPI common block 2017-11-11 18:20:12 +00:00
systemagent.c soc/intel/apollolake: Implement UNCORE PRMRR get base and mask API 2017-09-14 14:58:33 +00:00
uart.c soc/intel/apollolake: Clean up UART code 2017-12-07 03:21:13 +00:00
xdci.c Fix files with multiple newlines at the end. 2017-07-24 15:08:08 +00:00